✨ Add ordering and filtering when listing Functions #8229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giancarloromeo
added
the
a:webserver
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8229 +/- ##
==========================================
- Coverage 86.76% 85.38% -1.38%
==========================================
Files 1916 743 -1173
Lines 74032 34281 -39751
Branches 1300 175 -1125
==========================================
- Hits 64234 29272 -34962
+ Misses 9407 4952 -4455
+ Partials 391 57 -334
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Contributor
🧪 CI InsightsHere's what we observed from your CI run for a4a823a. ✅ Passed Jobs With Interesting Signals
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds ordering and filtering capabilities to the function listing endpoint. It enhances the API to support searching functions by title or multi-column search, as well as ordering results by different fields like creation date, modification date, or name.
- Adds query parameters for ordering, filtering, and searching functions
- Updates the REST schema to include new parameter types and validation
- Extends test coverage to verify the new ordering and filtering functionality
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
_functions_rest_schemas.py |
Defines new query parameter schemas for ordering, filtering, and search functionality |
_functions_rest.py |
Updates the list_functions endpoint to handle new ordering and filtering parameters |
openapi.yaml |
Adds new query parameters to the OpenAPI specification |
test_functions_controller_rest.py |
Adds comprehensive tests for the new ordering and filtering features |
services/web/server/tests/unit/with_dbs/04/functions/test_functions_controller_rest.py
Outdated
Show resolved
Hide resolved
services/web/server/tests/unit/with_dbs/04/functions/test_functions_controller_rest.py
Outdated
Show resolved
Hide resolved
giancarloromeo
requested review from
GitHK,
matusdrobuliak66,
pcrespov and
sanderegg
as code owners
odeimaiz
approved these changes
Aug 19, 2025
sanderegg
approved these changes
Aug 19, 2025
Member
sanderegg
left a comment
sanderegg
left a comment
There was a problem hiding this comment.
you might need to update the minor version of the webserver openapi? make version-minor or similar
Contributor
Author
Done, thanks for the command. |
Contributor
Author
|
@Mergifyio queue |
Contributor
🟠 Waiting for conditions to match
|
GitHK
approved these changes
Aug 19, 2025
services/web/server/tests/unit/with_dbs/04/functions/test_functions_controller_rest.py
Outdated
Show resolved
Hide resolved
|
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR adds ordering and filtering capabilities to the function listing endpoint. It enhances the API to support searching functions by title or multi-column search, as well as ordering results by different fields like creation date, modification date, or name.
Related issue/s
How to test
Dev-ops